#9412 ee10: Fixed missing callback failure when ws endpoint cannot b…

…e instantiated Signed-off-by: Ludovic Orban <[email protected]>
jetty · Mar 6, 2023 · 5bac801 · 5bac801
1 parent 474136d
commit 5bac801
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 2 deletions.
diff --git a/...ava/org/eclipse/jetty/ee10/websocket/jakarta/server/internal/JakartaWebSocketCreator.java b/...ava/org/eclipse/jetty/ee10/websocket/jakarta/server/internal/JakartaWebSocketCreator.java
@@ -166,9 +166,10 @@ public Map<String, Object> getUserProperties()
             Object endpoint = config.getConfigurator().getEndpointInstance(endpointClass);
             return new ConfiguredEndpoint(endpoint, config);
         }
-        catch (InstantiationException e)
+        catch (Throwable x)
         {
-            LOG.warn("Unable to create websocket: {}", config.getEndpointClass().getName(), e);
+            LOG.warn("Unable to create websocket: {}", config.getEndpointClass().getName(), x);
+            callback.failed(x);
             return null;
         }
     }

diff --git a/...java/org/eclipse/jetty/ee10/websocket/jakarta/tests/ProgrammaticWebSocketUpgradeTest.java b/...java/org/eclipse/jetty/ee10/websocket/jakarta/tests/ProgrammaticWebSocketUpgradeTest.java
@@ -35,16 +35,21 @@
 import org.eclipse.jetty.ee10.websocket.jakarta.client.JakartaWebSocketClientContainer;
 import org.eclipse.jetty.ee10.websocket.jakarta.server.JakartaWebSocketServerContainer;
 import org.eclipse.jetty.ee10.websocket.jakarta.server.config.JakartaWebSocketServletContainerInitializer;
+import org.eclipse.jetty.ee10.websocket.jakarta.server.internal.JakartaWebSocketCreator;
+import org.eclipse.jetty.logging.StacklessLogging;
 import org.eclipse.jetty.server.Server;
 import org.eclipse.jetty.server.ServerConnector;
 import org.eclipse.jetty.util.ajax.JSON;
+import org.eclipse.jetty.websocket.core.exception.UpgradeException;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.is;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
 
 public class ProgrammaticWebSocketUpgradeTest
 {
@@ -97,6 +102,20 @@ public void onOpen(Session session, EndpointConfig config)
         }
     }
 
+    public static class BrokenEndpoint extends Endpoint
+    {
+        public BrokenEndpoint()
+        {
+            throw new RuntimeException("Broken");
+        }
+
+        @Override
+        public void onOpen(Session session, EndpointConfig config)
+        {
+            throw new UnsupportedOperationException();
+        }
+    }
+
     public static class CustomUpgradeServlet extends HttpServlet
     {
         private JakartaWebSocketServerContainer container;
@@ -128,6 +147,12 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
                         container.upgradeHttpToWebSocket(request, response, sec, PATH_PARAMS);
                         break;
                     }
+                    case "/brokenEndpoint":
+                    {
+                        ServerEndpointConfig sec = ServerEndpointConfig.Builder.create(BrokenEndpoint.class, "/").build();
+                        container.upgradeHttpToWebSocket(request, response, sec, PATH_PARAMS);
+                        break;
+                    }
                     default:
                         throw new IllegalStateException();
                 }
@@ -155,6 +180,25 @@ public void testWebSocketUpgrade() throws Exception
         assertThat(socket.closeReason.getCloseCode(), is(CloseReason.CloseCodes.NORMAL_CLOSURE));
     }
 
+    @Test
+    public void testWebSocketUpgradeFailure() throws Exception
+    {
+        try (StacklessLogging ignore = new StacklessLogging(JakartaWebSocketCreator.class);)
+        {
+            URI uri = URI.create("ws://localhost:" + connector.getLocalPort() + "/brokenEndpoint");
+            EventSocket socket = new EventSocket();
+            try
+            {
+                client.connectToServer(socket, uri);
+                fail("expected IOException");
+            }
+            catch (IOException ioe)
+            {
+                assertInstanceOf(UpgradeException.class, ioe.getCause());
+            }
+        }
+    }
+
     @Test
     public void testPathParameters() throws Exception
     {