Karma-ing multiple people simultaneously #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2019 16:21
In order to parse karma for > 1 user at a time, we're going to need to be able to call a function doing the same thing over with a subset of the message. re: jetpackworkflow#10
If you have the message "@person1++ @Person2++ @person3-- @person4--", this will recursively add/remove karma to each of the people karma'ed. closes jetpackworkflow#10
|
See #13 instead! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a really ridiculously naive approach to handle this... There are 2 commits: 1 breaking out the parsing of the karma to a method, and the 2nd using recursion with that method to remove the first found "++"'ed or "--"'ed user/item from the message and see if there are any others.
Why we probably don't actually wanna do this
(I want to look into what is increasing the listener counts.. I'm assuming it's the passing of
robotintodoKarmainstead of initializing aParseKarmawith the robot...)QA Steps
thing1++ and also thing2++Related Issue
closes #10