Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add scroll sensitivity configuration and improved wheel event h… #242

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

adamshiervani
Copy link
Contributor

Improve scrolling and add a setting for slow, default and High

Added a new store called DeviceSettingsStore. We should migrate all settings there and get all the relevant ones on page load. Currently, some settings are in Localstorage, and some stored on device - causes both confusion and bugs. We should move all the settings to the DeviceSettingsStore moving forward. Didn't want to blow this PR up, so migrating other settings will be done later.

…andling

- Implement scroll sensitivity settings with low, default, and high modes
- Add RPC methods for getting and setting scroll sensitivity
- Enhance wheel event handling with device-specific sensitivity and clamping
- Create a new device settings store for managing scroll and trackpad parameters
- Update mouse settings route to include scroll sensitivity selection
Copy link
Contributor

@ym ym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamshiervani adamshiervani merged commit 536e823 into dev Mar 10, 2025
2 of 3 checks passed
@adamshiervani adamshiervani deleted the feat/better-scrolling branch March 10, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants