[PROPOSAL] postgresql process-compose is faulty when $PGHOST contains blank space #2399
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct path The postgresql process compose is faulty, as it does not properly escape the PGHOST variable. When a blank space is anywhere in the absolute path of the project, pg_ctl will interpret the blank space as a new argument, instead of being part of the path argument. Signed-off-by: Robin Bardakcioglu <[email protected]>
Lagoja
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please view this PR as a bug report and proposal for a fix, and not a finished feature implementation.
When we were working with devbox we realised we had errors on some of our machines. After some debugging we found that
devbox services start postgresqldid not work properly on machines, where the absolute path to the project contained a blank space. This change in the process-compose was what fixed the issue for us.I did not perform any due dilligence in checking or testing if this proposed change does not introduce a breaking change for other consumers. I am merely proposing a change that has worked for us personally.
Summary
The postgresql process compose is faulty, as it does not properly escape the PGHOST variable. When a blank space is anywhere in the absolute path of the project, pg_ctl will interpret the blank space as a new argument, instead of being part of the path argument.
How was it tested?
WIP, the change was tested locally in an extra process-compose.yml that was not part of the plugin. This PR merely suggests that the change may be applied to the plugin. However I have not done any testing and this PR SHOULD NOT BE MERGED AS IS.
As the change is only trivial I used the PR to notify of the issue, since this makes it much clearer what the problem was.