shellgen: delete flake.lock if flake.nix changes #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where `.devbox/gen/flake` gets locked on old versions of `.devbox/gen/flake/glibc-patch` by deleting the `flake.lock` file. We only delete the lock file when the generated flake changes so that Nix isn't forced to re-evaluate it every time. The repro steps are: 1. Add a package that gets auto-patched (`devbox add [email protected]`). 2. `.devbox/gen/flake` gets locked on the patch flake. 3. Change the patched package (`devbox add [email protected]`). 4. The new patch flake isn't used because of `.devbox/gen/flake/flake.lock`. Instead, the old version is used (from the Nix store). Fixes #2316. Fixes #2370.
savil
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where
.devbox/gen/flakegets locked on old versions of.devbox/gen/flake/glibc-patchby deleting theflake.lockfile.We only delete the lock file when the generated flake changes so that Nix isn't forced to re-evaluate it every time.
The repro steps are:
devbox add [email protected])..devbox/gen/flakegets locked on the patch flake.devbox add [email protected])..devbox/gen/flake/flake.lock. Instead, the old version is used (from the Nix store).Fixes #2316.
Fixes #2370.