patchpkg: use devbox flake instead of local binary #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the patching flake to use the devbox flake (added in 37c36a1) instead of copying the binary manually. - It uses the flakeref `"github:jetify-com/devbox/" + build.Version` to get the same version of Devbox that's currently running. - For dev builds, it attempts to find the devbox source and use the local flake instead. When Devbox needs to patch a package, it generates a flake that calls `devbox patch` as its builder. Because flake builds are sandboxed, we need a way of getting devbox into the Nix store. Previously, we were just copying the currently running devbox executable into the Nix store and using that. However, Devbox isn't actually a static binary (we don't build with CGO_ENABLED=0). This causes `devbox patch` to fail because the flake is isolated from the system's linker.
savil
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the patching flake to use the devbox flake (added in 37c36a1) instead of copying the binary manually.
"github:jetify-com/devbox/" + build.Versionto get the same version of Devbox that's currently running.When Devbox needs to patch a package, it generates a flake that calls
devbox patchas its builder. Because flake builds are sandboxed, we need a way of getting devbox into the Nix store.Previously, we were just copying the currently running devbox executable into the Nix store and using that. However, Devbox isn't actually a static binary (we don't build with CGO_ENABLED=0). This causes
devbox patchto fail because the flake is isolated from the system's linker.