Replace CallableSignature with FunctionTypeEmbedding #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CallableSignature` stores the type information about the type signature; previously, we wrapped it in a special `data` class and then passed that data to `FunctionTypeEmbedding`, but this is roundabout and doesn't actually help. This change simplifies things by just keeping the type embedding directly.
francescoo22
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CallableSignaturestores the type information about the type signature; previously, we wrapped it in a specialdataclass and then passed that data toFunctionTypeEmbedding, but this is roundabout and doesn't actually help. This change simplifies things by just keeping the type embedding directly.