Group attachments #535
Comments
|
@branden-eyk could you take a look at this one? |
|
For context, in any messageboard (events, groups, courses) the user is permitted to attach files. When the user attaches a file at the moment, the file appears to be attached and the UI works, but when the user then clicks on the file to download it, the screenshot in this issue appears. |
|
This may have to do with special characters and spaces in the file name when it is uploaded. Suggest testing a few different uploads to see what works and doesn't. |
|
@GeorgeBellTMH That was my first thought; I've seen similar things to this in other things I've created/worked with. I'll start as you suggested. |
|
Semi-related: when I click on a group on the dev page the screen is blank and never loads. Is that normal? Works fine for me in beta. |
|
Also since you have access you can check that the file is getting uploaded to s3...the bucket and key should be in the code. |
|
@branden-eyk I've fixed the white screen problem...my bad...pull the latest and it should be working. |
|
@GeorgeBellTMH thanks George! It's working for me now! One other question: was the upload functionality disabled? I don't see the button to upload anymore. I was telling Lucas on Friday, I think it's the filenames that were causing the issue. I just want to do an upload in a group or event to confirm that. |
|
@branden-eyk I noticed that as well, and I think I know why. @GeorgeBellTMH moved some stuff around and he's removed formatting from the message board (which I actually like) to match the design. However, without it, we don't have an attach function. @GeorgeBellTMH what are your thoughts about adding a secondary button beside "post" that says "attach a file"? |
|
@branden-eyk @GeorgeBellTMH attachments still exist in courses, but they are not working. There is a course starting in 10 days so we need to make sure attachments are working by then. Look at this course in beta and check out the "learning guide" for download. https://beta.jesuscollective.com/app/course?create=false&id=course-1616018842166 |
|
@GeorgeBellTMH this wouldn't happen to be related to #494 would it? I think, given some time, I could handle that one. But if there's a time limit of 10 days, I'm not confident I could meet it. |
|
Yup it's the same I think. Lucas can you test if the spaces is causing an issue? Maybe name the file something simple before you upload it... |
|
@GeorgeBellTMH it looks like Jon removed the formatting toolbar at my request as per issue #160 which means now we can't upload files. This is a mistake on my part. That was a me being a stickler for following the design. My bad! :( Can we add the toolbar back so users can upload attachments? We don't even need the whole toolbar, just a way to upload files. Will doing this mess the UI in courses now? |
|
Ok, toolbar is back... |
|
@branden-eyk now that this is back, any chance you can take a look pls? |
|
@lucastbelem Is it back? I still don't see a way to upload attachments in groups or otherwise. I've checked both dev and beta. Sorry if I'm missing something really obvious. My jumping in and out of this makes it hard for me to keep up. |
|
Hey dude,
It's back, but only in courses. I did a quick test and it seems to work ok
right now.
Maybe let's leave this one aside. Wanna focus instead on the dashboard
arrows?
…On Tue, Mar 30, 2021 at 2:49 PM branden-eyk ***@***.***> wrote:
@lucastbelem <https://github.com/lucastbelem> Is it back? I still don't
see a way to upload attachments in groups or otherwise. I've checked both
dev and beta. Sorry if I'm missing something really obvious. My jumping in
and out of this makes it hard for me to keep up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#535 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQO6JUJLJCIWHAF6VNA3ODTGIMNPANCNFSM4VEYF5QA>
.
--
*Lucas Belem*
Communications Project Manager
The Meeting House
2700 Bristol Circle | Oakville, ON | L6H 6E1
p: 905.287.7000, ext. 821 | f: 905.287.7099
www.themeetinghouse.com
*This email, including attachments, is for the sole use of the intended
recipient and may contain confidential information. If you are not the
intended recipient, any disclosure, copying or distribution of the
information is prohibited. If this email was received in error, please
notify us by reply email and delete the original message.*
|
|
Ok. I've potentially got a couple functions built that'll strip spaces and special characters that aren't web safe from filenames when they are uploaded...but I can't test it until I can actually get to a place I can test uploads. So I'll move on to something else for now. |
|
@branden-eyk if I give you access, what are the chances you work on it today or tomorrow? |
|
@lucastbelem I could definitely spend time on it tomorrow. Whether what I've written will actually work in the context of a REACT Native application is another story. But I won't know until I can test it anyways... |
|
Closing because the issue is solved, but attachments aren't possible on groups and events. |
When attachments are added to groups, they add properly, but when user downloads, this is the screen seen:
The text was updated successfully, but these errors were encountered: