chore: add explicit-module-boundary-types lint rule #9539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've found that type errors can be quite hard to understand when there are many layers of inference between the actual source of the type error and where it shows up as an actual type error. By typing all exported functions within a single file, any type error should at least have its origin within one file, instead of having to dig though multiple layers.
Rule docs: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/explicit-module-boundary-types.md
One annoying thing is that it doesn't recognise
any
as a type, which is somewhat painful in certain circumstances (like for matchers inexpect
)Test plan
Green CI