docs: add comment about 'cleanup' in react-testing-library example#9144
Merged
SimenB merged 1 commit intojestjs:masterfrom Nov 9, 2019
Merged
docs: add comment about 'cleanup' in react-testing-library example#9144SimenB merged 1 commit intojestjs:masterfrom
SimenB merged 1 commit intojestjs:masterfrom
Conversation
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-testing-libraryautomatically runscleanupunless otherwise specified (testing-library/react-testing-library#430). The change takes place in@testing-library/react@9.0.0(https://github.com/testing-library/react-testing-library/releases/tag/v9.0.0) and later.I found the documentation to be contradictory as to whether
afterEach(cleanup)should be called, and so hopefully this comment clarifies it for future users.Test plan
This is just adding a comment, so I do not believe any test plan is necessary.