Skip to content

Suggesting to use node 12 as default #9098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 3 commits into from
Oct 26, 2019
Merged

Suggesting to use node 12 as default #9098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44dde83
chore: fix linting error on node 12.x
sairus2k Oct 26, 2019
5e4c62c
ci: set node 12.x for linting and typechecking
sairus2k Oct 26, 2019
3619809
docs: set node 12.x as recommended for contributing
sairus2k Oct 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
lint-and-typecheck:
working_directory: ~/jest
docker:
- image: circleci/node:10
- image: circleci/node:12
steps:
- checkout
- restore-cache: *restore-cache
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ _Before_ submitting a pull request, please make sure the following is done…
python --version
```

1. Make sure you have a compatible version of `node` installed (As of July 10th 2019, `v10.x` is recommended since there is a known issue with `v12.x` [#8490](https://github.com/facebook/jest/issues/8490)).
1. Make sure you have a compatible version of `node` installed (As of October 25th 2019, `v12.x` is recommended).

```sh
node -v
Expand Down
2 changes: 0 additions & 2 deletions packages/jest-worker/src/workers/NodeThreadsWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

import * as path from 'path';
import {PassThrough} from 'stream';
// ESLint doesn't know about this experimental module
// eslint-disable-next-line import/no-unresolved
import {Worker} from 'worker_threads';
import mergeStream = require('merge-stream');

Expand Down
2 changes: 0 additions & 2 deletions packages/jest-worker/src/workers/threadChild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
* LICENSE file in the root directory of this source tree.
*/

// ESLint doesn't know about this experimental module
// eslint-disable-next-line import/no-unresolved
import {isMainThread, parentPort} from 'worker_threads';

import {
Expand Down