chore: test on node 13

[SimenB]

Summary

Node 13 is out, so let's test on it. (I haven't ran this locally 🤞).

Also move typecheck, website and circus from node 10 to 12, as 12 is now LTS moved to (and merged from) #9100

Test plan

Green CI

[SimenB]

@arcanis thoughts on the pnp test failure?

[arcanis]

I'm unfortunately without laptop this week, but I can look into it next Monday! It seems that the signature of Module._findPath changed, weird 🤔

[sairus2k]

Related issue yarnpkg/yarn#7642

[SimenB]

Manually added the change in yarnpkg/yarn#7650. A distinct advantage of checking in a version of yarn 👍

[codecov-io]

Codecov Report

Merging #9088 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9088   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files         277      277           
  Lines       11707    11707           
  Branches     2874     2874           
=======================================
  Hits         7578     7578           
  Misses       3512     3512           
  Partials      617      617

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2c92b...5501f5e. Read the comment docs.

[SimenB]

@arcanis I assume it's safe? I just added || [], and CI passed at least

[SimenB]

Can revert if not

[arcanis]

@SimenB yep, that's the right change!

Manually added the change in yarnpkg/yarn#7650. A distinct advantage of checking in a version of yarn 👍

And just wait until your hear about yarn set version from sources --branch <pr#> (v2 only) 😛

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.