-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marker at first place of string mismatch #8400
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
super cool idea, thanks for the PR! we've talked about substring diff highlighting before (#4619), but this might be a start that somewhat allows the feature? I'll defer to @pedrottimark here 🙂 |
Love the idea. Thanks for the PR. The failing tests show a bug or two:
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Addresses #6881
Summary
This is not final rather just a step I think, want to get your feedback and move accordingly.
Regarding the diffLocation() there might be a little extra performance usage here with the ^ location output I couldn't find the other code that generates it below.
Regarding the spaces discussion in #6881 I think if the spaces are shown with marker it should be obvious to 9/10 people that there is a difference there can add another section that shows if first character that is different is a xA0, em-dash, x20, dash, or similar then output symbol hex as well (Expected: 1x20234)