chore: use types from @jest/reporter in @jest/core #8045
Conversation
| @@ -158,10 +158,20 @@ export default class ChildProcessWorker implements WorkerInterface { | |||
| } | |||
|
|
|||
| getStdout(): NodeJS.ReadableStream { | |||
| if (this._child.stdout === null) { | |||
| throw new Error( | |||
| 'stdout is null - this should never happen. Please open up an issue at https://github.com/facebook/jest', | |||
There was a problem hiding this comment.
when actually this can happen?
There was a problem hiding this comment.
I have no idea. It's from DefinitelyTyped/DefinitelyTyped#33127
There was a problem hiding this comment.
felt better to add an explicit error rather than ignoring the type error
|
I think |
| @@ -4,14 +4,14 @@ | |||
| "rootDir": "src", | |||
| "outDir": "build" | |||
| }, | |||
| // TODO: This is missing `@jest/reporters` | |||
There was a problem hiding this comment.
should have done this when I merged #7994 yesterday 😅 The typings disagreed as well, interestingly enough (which is why it raised an error now)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Forgot to clean this up, and (probably due to a race condition due to missing
referencesentry) this didn't show up on CI.Test plan
Green CI