nodejs instanceof array e2e test and fix

[chekkan]

Summary

This is to contribute to the pull request #5995.

Added e2e test for Array instanceof error. I was able to reproduce this error locally with jest version 24.1.0 and "testEnvironment": "node" as reported in the original issue #2549. And verified this change against it and saw it working.

I couldn't reproduce this issue in "testEnvironment": "jsdom". And I couldn't fail the e2e tests against node version 6, 8, and 10 as well.

Test plan

Node version 6

node --version
v6.14.3
➜ pwd
/Users/chekkan/dev/facebook/jest/e2e/instanceof
➜ node ../../packages/jest-cli/bin/jest.js
 PASS  __tests__/test.js
  ✓ fs Error (5ms)
  ✓ http error (96ms)
  ✓ querystring parse array (1ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        1.051s
Ran all test suites.

Node version 8

➜ node --version
v8.11.1
➜ pwd
/Users/chekkan/dev/facebook/jest/e2e/instanceof
➜ node ../../packages/jest-cli/bin/jest.js
 PASS  __tests__/test.js
  ✓ fs Error (4ms)
  ✓ http error (14ms)
  ✓ querystring parse array (3ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        0.798s
Ran all test suites.

Node version 10

➜ node --version
v8.11.1
➜ pwd
/Users/chekkan/dev/facebook/jest/e2e/instanceof
➜ node ../../packages/jest-cli/bin/jest.js
 PASS  __tests__/test.js
  ✓ fs Error (4ms)
  ✓ http error (13ms)
  ✓ querystring parse array (1ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        0.763s
Ran all test suites.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[SimenB]

I'm excited! Thanks for picking this up.

CI is failing, and there are some conflicts. Mind taking a look? 🙂

[github-actions]

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.