-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create @jest/core package #7696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of doing this progressively, even if the boundary between jest-cli
and jest-core
isn't clear yet. I'd keep the README in jest-cli
and have a temporary one in jest-core
specifying it's internal and unstable to use directy.
@rubennorte if you merge this, make sure to get publish access from @cpojer to |
hell yeah |
40563b8
to
42e8089
Compare
Made it non-breaking ( ( |
Codecov Report
@@ Coverage Diff @@
## master #7696 +/- ##
==========================================
- Coverage 58.32% 58.31% -0.01%
==========================================
Files 164 163 -1
Lines 6047 6046 -1
Branches 5 5
==========================================
- Hits 3527 3526 -1
Misses 2518 2518
Partials 2 2
Continue to review full report at Codecov.
|
Holy shit, this PR is a dream come true. Amazing @SimenB, thank you! |
🎉 I've also split out |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
We want to provide a programmatic API. A first step is to make
jest-cli
actually just deal with the CLI, and not everything else. We probably wanna makejest-core
(or whatever it ends up being named) have a better API - for now it just expects a massagedargv
object, which in theory can be constructed however you want.We've discussed this briefly before, I just wanted to see how much work just the split was.
No hard feelings if it's not merged 🙂
I kept
yargs
and--init
functionality injest-cli
Test plan
Green CI?