Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jest 24 blog post #7670

Merged
merged 28 commits into from
Jan 25, 2019
Merged

Add Jest 24 blog post #7670

merged 28 commits into from
Jan 25, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 21, 2019 •
edited
Loading

Summary

After the alpha is tested at FB, we should be ready for stable release. At that point, merge this and #7566 🙂

Test plan

Check it out on the netlify preview: https://deploy-preview-7670--jest-preview.netlify.com/blog/2019/01/23/jest-24-refreshing-polished-typescript-friendly

@SimenB SimenB added this to the Jest 24 milestone Jan 21, 2019
SimenB
SimenB commented Jan 21, 2019
View reviewed changes
website/blog/2019-01-21-jest-24-new-website-babel-7-and-typescript-support.md Outdated
@@ -0,0 +1,94 @@
---
Copy link
Member Author

@SimenB SimenB Jan 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to self, remember to rename this post to have the correct date before landing

rickhanlonii
rickhanlonii approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few suggestions 👍

website/blog/2019-01-21-jest-24-new-website-babel-7-and-typescript-support.md Outdated Show resolved Hide resolved
website/blog/2019-01-21-jest-24-new-website-babel-7-and-typescript-support.md Outdated Show resolved Hide resolved
website/blog/2019-01-21-jest-24-new-website-babel-7-and-typescript-support.md Outdated Show resolved Hide resolved
website/blog/2019-01-21-jest-24-new-website-babel-7-and-typescript-support.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #7670 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7670   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files         251      251           
  Lines        9667     9667           
  Branches        6        5    -1     
=======================================
  Hits         6600     6600           
  Misses       3065     3065           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd4f53...26108df. Read the comment docs.

cpojer
cpojer approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You guys rock. Good stuff.

mattphillips
mattphillips approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@mattphillips mattphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 👏

thymikee
thymikee approved these changes Jan 22, 2019
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

rubennorte
rubennorte approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@rubennorte rubennorte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for working on this! 🎉

@SimenB SimenB merged commit 9ac5d4a into jestjs:master Jan 25, 2019
@SimenB SimenB deleted the jest-24-blogpost branch January 25, 2019 15:13
@DylanVann
Copy link
Contributor

@SimenB I think you forgot the note about changing the filename. Is today the day?

@SimenB
Copy link
Member Author

SimenB commented Jan 25, 2019 •
edited
Loading

gah. thanks! e2d80e7

Is today the day?

$ yarn info jest dist-tags
yarn info v1.13.0
{ latest:
   '24.0.0',
  test:
   '21.3.0-beta.15',
  beta:
   '24.0.0-alpha.16' }
✨  Done in 0.13s.

@SimenB
Copy link
Member Author

SimenB commented Jan 25, 2019

https://jestjs.io/blog/2019/01/25/jest-24-refreshing-polished-typescript-friendly

Thanks everyone!

captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@SimenB @captain-yossarian
Add Jest 24 blog post (jestjs#7670)
37ed647
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeysal jeysal jeysal approved these changes

@pedrottimark pedrottimark pedrottimark left review comments

@ikatyang ikatyang ikatyang left review comments

@thymikee thymikee thymikee approved these changes

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@DylanVann DylanVann DylanVann left review comments

@orta orta orta left review comments

@cpojer cpojer cpojer approved these changes

@mattphillips mattphillips mattphillips approved these changes

@rubennorte rubennorte rubennorte approved these changes

@rogeliog rogeliog Awaiting requested review from rogeliog

@mjesun mjesun Awaiting requested review from mjesun

@aaronabramov aaronabramov Awaiting requested review from aaronabramov

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
Jest 24
Development

Successfully merging this pull request may close these issues.