Accept additional cache keys for haste map #7350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
force-pushed
the
accept-additional-cache-keys-for-haste-map
branch
from
68698c9
to
5998235
Compare
|
Right now it includes the changes in #7349. I'll rebase once that one is merged. |
rubennorte
force-pushed
the
accept-additional-cache-keys-for-haste-map
branch
3 times, most recently
from
ff5096d
to
7b198a2
Compare
mjesun
suggested changes
Nov 9, 2018
rubennorte
force-pushed
the
accept-additional-cache-keys-for-haste-map
branch
from
7b198a2
to
034abd6
Compare
mjesun
approved these changes
Nov 9, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now the
hasteImplModulePath(used to extract "global" module names from file paths) anddependencyExtractoroptions are not taken into account to compute the cache key for the haste map. Those options affect a great deal how the haste map is generated, so if they change the haste map should be regenerated (e.g. if we change the dependency extractor to add a new type of dependency, they won't be included in the files that are currently cached in the haste map).Test plan
Added unit tests to check this.