Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regular expression for matching message for findMessageType #7029

Merged
merged 1 commit into from
Sep 23, 2018

Conversation

natealcedo
Copy link

Summary

This pull request updates the regular expression that was wrongly written in #7028 where the tests were passing because the tests were written wrongly. The quotation marks were missing in the regular expression.

Test plan

The tests in jest-editor-support/src/__tests__/runner.tests.js have been updated with the the quotation marks in place.

@codecov-io
Copy link

Codecov Report

Merging #7029 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7029   +/-   ##
=======================================
  Coverage   66.95%   66.95%           
=======================================
  Files         250      250           
  Lines       10430    10430           
  Branches        4        4           
=======================================
  Hits         6983     6983           
  Misses       3446     3446           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-editor-support/src/Runner.js 74.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df78b49...114ae0b. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!

@SimenB SimenB merged commit 37caedd into jestjs:master Sep 23, 2018
@natealcedo natealcedo deleted the fix_regular_expression branch September 26, 2018 01:23
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants