Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: symlinks in node_modules #6993

Closed
wants to merge 3 commits into from
Closed

feat: symlinks in node_modules #6993

wants to merge 3 commits into from

Commits on Oct 21, 2018

  1. feat: symlinks in node_modules 

    - add `follow` method to `HasteFS` class
- add `links` property to `InternalHasteMap` type
- add `LinkData` map type
- add `LinkMetaData` array type

The user will need Watchman installed for this commit to take effect. Support for the Node crawler should be added in a future commit.

Only symlinks matching `node_modules/*` or `node_modules/@*/*` are stored in the `links` property. For each symlink found, a `[target, mtime]` tuple is created. The `target` value is undefined until `hasteFS.follow` uses `fs.realpathSync` to resolve the symlink. In this way, symlinks are lazily resolved and then cached.
    @aleclarson
    aleclarson committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    8d51463 View commit details
    Browse the repository at this point in the history

  2. use realpath-native

    @aleclarson
    aleclarson committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    9c29b39 View commit details
    Browse the repository at this point in the history

  3. update CHANGELOG

    @aleclarson
    aleclarson committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    91ff8a8 View commit details
    Browse the repository at this point in the history