Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] add note explaining when jest.setTimeout should be called #6817

Merged
merged 2 commits into from
Aug 10, 2018

Conversation

ftes
Copy link
Contributor

@ftes ftes commented Aug 9, 2018

Summary

Improve documentation of jest.setTimeout (so that consumers use it correctly, e.g. see #6557).

Test plan

None (documentation only).

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update other versions files (22.x, 23.x) and master doc as well?

@codecov-io
Copy link

Codecov Report

Merging #6817 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6817   +/-   ##
=======================================
  Coverage   63.55%   63.55%           
=======================================
  Files         235      235           
  Lines        9030     9030           
  Branches        3        3           
=======================================
  Hits         5739     5739           
  Misses       3290     3290           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db28956...2e4b4be. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ftes ftes force-pushed the feature/improve-settimeout-doc branch from 2e4b4be to c5a7da0 Compare August 10, 2018 14:52
@ftes
Copy link
Contributor Author

ftes commented Aug 10, 2018

@thymikee done

@thymikee
Copy link
Collaborator

Can you also update the changelog pls? :)

@thymikee thymikee merged commit 9093a3c into jestjs:master Aug 10, 2018
@thymikee
Copy link
Collaborator

Thank you!

@ftes ftes deleted the feature/improve-settimeout-doc branch December 18, 2018 06:50
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants