-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow detectOpenHandles in jest.config.js #6747
Conversation
LGTM! @clarkdo could you add an entry to the changelog? |
As mentioned in another issue (on mobile, so hard to dig up), |
37e6d46
to
8f00aa1
Compare
@mattphillips Done |
Codecov Report
@@ Coverage Diff @@
## master #6747 +/- ##
=======================================
Coverage 63.44% 63.44%
=======================================
Files 235 235
Lines 9112 9112
Branches 4 4
=======================================
Hits 5781 5781
Misses 3330 3330
Partials 1 1
Continue to review full report at Codecov.
|
The related comment that @SimenB mentioned: #6130 (comment) |
Would love to see this goes in @clarkdo |
@SimenB if we document the performance hit, would you be ok to add this to the config? |
This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Current if config
detectOpenHandles
injest.config.js
, validation warning will be thrown:Resolve warning in nuxt/nuxt#3581