Fix tests for recent broader-options watch plugins PR #6696
+64
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A test inside #6473 was unfortunately incorrect and "passed by mistake". This was due to the TTS or an
it.each
call not using interpolation on dynamic scenario variables, mostly. This fixes it.Additionally, in the meantime an extra call to
updateGlobalConfig
had been added to each watch test run, making the original test obsolete in its mock calls inspection. Updated.Test plan
Well, the tests keep passing, only this time they're correct 😉 so they're actually exercising the scenarios.
Ping @rogeliog @thymikee @SimenB for review.
Refs #6693