Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reporters' config #6542

Merged
merged 7 commits into from
Aug 16, 2018
Merged

Fix reporters' config #6542

merged 7 commits into from
Aug 16, 2018

Commits on Aug 15, 2018

  1. Fix reporters to handle string params 

    Documentation shows reporters as `reporters [array<moduleName | [moduleName, options]>]`, the code was incorrectly handling the following cases:

```
// no `string` moduleName
// _addCustomReporters(reporters: Array<ReporterConfig>)
reporters: ['default', 'someother']

// _shouldAddDefaultReporters(reporters?: Array<ReporterConfig>): boolean {
reporters: [['default', {}], 'someother']
```

This fix, use  the already existing `_getReporterProps` to compare `{path} === 'default'`.
    @artola
    artola committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    257cc2f View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @artola
    artola committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    bd778fb View commit details
    Browse the repository at this point in the history

  3. Update Config.js

    @artola
    artola committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    23730f4 View commit details
    Browse the repository at this point in the history

  4. prettier code

    @artola
    artola committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    09c3105 View commit details
    Browse the repository at this point in the history

  5. prettier code

    @artola
    artola committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    8b3c2d0 View commit details
    Browse the repository at this point in the history

  6. regression test 

    - config for reporters supports `default`
    @artola
    artola committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    5ebd1ce View commit details
    Browse the repository at this point in the history

  7. Update CHANGELOG.md

    @artola
    artola committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    8cb41d3 View commit details
    Browse the repository at this point in the history