mock console.log to reduce noise from the tests #6526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Jun 22, 2018
ranyitz
force-pushed
the
reduce-init-tests-console-noise
branch
from
1799cfa
to
7464879
Compare
thymikee
force-pushed
the
reduce-init-tests-console-noise
branch
from
7464879
to
b1620e6
Compare
thymikee
approved these changes
Aug 8, 2018
Codecov Report
@@ Coverage Diff @@
## master #6526 +/- ##
=======================================
Coverage 63.55% 63.55%
=======================================
Files 235 235
Lines 9030 9030
Branches 3 3
=======================================
Hits 5739 5739
Misses 3290 3290
Partials 1 1Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following to @SimenB's advice, mock
console.logininittests to reduce noise.Test plan
All tests pass (without nonessential logs)