-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest-each]: Add support for keyPaths in test titles #6457
Merged
cpojer
merged 10 commits into
jestjs:master
from
mattphillips:jest-each-template-keypath
Jun 20, 2018
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
611dbf8
Add support for keyPaths in test titles
mattphillips 6b98ef1
Move getPath from expect/utils to jest-util
mattphillips 0f0066a
Add changelog entry
mattphillips 776da62
Add keypath interpolation docs
mattphillips c7184d5
Add missing license and flow comments
mattphillips 8853f40
Revert "Move getPath from expect/utils to jest-util"
mattphillips 6d17440
Refactor getPath to be simplier
mattphillips fbdbcb6
Remove unused code
mattphillips 341997a
Fix changelog link
mattphillips ff60085
Merge branch 'master' into jest-each-template-keypath
cpojer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've inlined this for now to get it working, it shouldn't stay here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just use
lodash.get
or something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think we were using
lodash
anywhere? ThisgetPath
algorithm is used in thetoHaveProperty
matcher and offers a nicer returned value thanlodash
as it tracks the last visited object.EDIT: see expect utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sticking it in jest-utils should be fine for sharing (although @cpojer hates the util package :D)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I move it as part of this PR or would it be better in a separate PR?