fix the #6167 - F key misleading message

[lgandecki]

Summary

Fixes #6167

Changed the
"Press f to run all tests. " to "Press f to quit "only failed tests" mode" when inside only failed tests mode.

Test plan

Scenario is covered by the "shows the correct usage for the f key in "only failed tests" mode".
Also:

And

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[codecov-io]

Codecov Report

Merging #6182 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6182      +/-   ##
==========================================
+ Coverage   64.19%   64.32%   +0.13%     
==========================================
  Files         219      219              
  Lines        8423     8423              
  Branches        3        4       +1     
==========================================
+ Hits         5407     5418      +11     
+ Misses       3015     3004      -11     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-cli/src/watch.js	79.02% <ø> (+6.99%)	⬆️
packages/jest-cli/src/get_no_test_found_failed.js	0% <ø> (ø)	⬆️
packages/jest-cli/src/lib/update_global_config.js	91.66% <0%> (+4.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae3e40...0917645. Read the comment docs.

[SimenB]

Does this fix the case reported in #6167? While I think this message is clearer, it's unclear to me how it would fix the bug?

[lgandecki]

As far as I understood and verified the bug is actually about displaying a wrong information, the behavior is correct.
The keys are doing what they are supposed to be doing - (edited: which is, they switch on and off respective modes. )
One more improvement that we could do here is that while you are in "failed tests only" mode and you press a, it would also disable the "failed tests only" mode.

[SimenB]

Oh, that's a very good point. It's just confusing that the message is the same 🙂

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.