-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add summary_reporter.test.js #5389
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
aeb8170
add special option -- for npm update command
kdnakt 270362a
Update CHANGELOG.md
kdnakt d7473dd
Merge branch 'master' into fix-update-command-npm
kdnakt 8457640
add testcase for summary_reporter.js
kdnakt f8b7082
Merge branch 'fix-update-command-npm' of https://github.com/kdnakt/je…
kdnakt 80cd696
add testcase for yarn
kdnakt 9a26ddb
Merge branch 'master' into fix-update-command-npm
kdnakt 85d5b9d
Update CHANGELOG.md
kdnakt c5bdfa3
import SummaryReporter at the top
kdnakt 210987e
remove duplicated definition of results
kdnakt 85707c6
remove description
kdnakt 8f99c3e
add snapshot test
kdnakt c2b608a
update test title
kdnakt 38c10f8
remove duplicated line
kdnakt 480269f
add missing attributes for test results
kdnakt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
packages/jest-cli/src/reporters/__tests__/__snapshots__/summary_reporter.test.js.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`snapshots needs update with npm test 1`] = ` | ||
"<bold>Snapshot Summary</> | ||
<bold><red> › 2 snapshot tests</></> failed in 1 test suite. <dim>Inspect your code changes or run \`npm test -- -u\` to update them.</> | ||
|
||
<bold>Test Suites: </><bold><red>1 failed</></>, 1 total | ||
<bold>Tests: </><bold><red>1 failed</></>, 1 total | ||
<bold>Snapshots: </><bold><red>2 failed</></>, 2 total | ||
<bold>Time:</> 0.01s | ||
<dim>Ran all test suites</><dim>.</> | ||
" | ||
`; | ||
|
||
exports[`snapshots needs update with yarn test 1`] = ` | ||
"<bold>Snapshot Summary</> | ||
<bold><red> › 2 snapshot tests</></> failed in 1 test suite. <dim>Inspect your code changes or run \`yarn test -u\` to update them.</> | ||
|
||
<bold>Test Suites: </><bold><red>1 failed</></>, 1 total | ||
<bold>Tests: </><bold><red>1 failed</></>, 1 total | ||
<bold>Snapshots: </><bold><red>2 failed</></>, 2 total | ||
<bold>Time:</> 0.01s | ||
<dim>Ran all test suites</><dim>.</> | ||
" | ||
`; |
60 changes: 60 additions & 0 deletions
60
packages/jest-cli/src/reporters/__tests__/summary_reporter.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/** | ||
* Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
'use strict'; | ||
|
||
import SummaryReporter from '../summary_reporter'; | ||
|
||
const env = Object.assign({}, process.env); | ||
const now = Date.now; | ||
const write = process.stderr.write; | ||
const globalConfig = { | ||
watch: false, | ||
}; | ||
const aggregatedResults = { | ||
numFailedTestSuites: 1, | ||
numFailedTests: 1, | ||
numPassedTestSuites: 0, | ||
numTotalTestSuites: 1, | ||
numTotalTests: 1, | ||
snapshot: { | ||
filesUnmatched: 1, | ||
total: 2, | ||
unmatched: 2, | ||
}, | ||
startTime: 0, | ||
testResults: {}, | ||
}; | ||
|
||
let results = []; | ||
|
||
beforeEach(() => { | ||
process.env.npm_lifecycle_event = 'test'; | ||
process.env.npm_lifecycle_script = 'jest'; | ||
process.stderr.write = result => results.push(result); | ||
Date.now = () => 10; | ||
}); | ||
|
||
afterEach(() => { | ||
results = []; | ||
process.env = env; | ||
process.stderr.write = write; | ||
Date.now = now; | ||
}); | ||
|
||
test('snapshots needs update with npm test', () => { | ||
process.env.npm_config_user_agent = 'npm'; | ||
const testReporter = new SummaryReporter(globalConfig); | ||
testReporter.onRunComplete(new Set(), aggregatedResults); | ||
expect(results.join('')).toMatchSnapshot(); | ||
}); | ||
|
||
test('snapshots needs update with yarn test', () => { | ||
process.env.npm_config_user_agent = 'yarn'; | ||
const testReporter = new SummaryReporter(globalConfig); | ||
testReporter.onRunComplete(new Set(), aggregatedResults); | ||
expect(results.join('')).toMatchSnapshot(); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, forgot about adding
@flow
pragma here. See how it's done in other files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
@flow
made the test fail ...And other *.test.js files also don't have
@flow
pragma. So is it possible to skip adding it here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, forgot we only added it to integration tests. Cool, we can skip it for now.