Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use SSH with the new publish bot #5229

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Do not use SSH with the new publish bot #5229

merged 1 commit into from
Jan 4, 2018

Conversation

JoelMarcey
Copy link
Contributor

No description provided.

@JoelMarcey
Copy link
Contributor Author

@SimenB We had SSH turned on and we didn't need it for this. That was our problem, I believe.

@codecov-io
Copy link

Codecov Report

Merging #5229 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5229   +/-   ##
=======================================
  Coverage   60.91%   60.91%           
=======================================
  Files         202      202           
  Lines        6731     6731           
  Branches        4        4           
=======================================
  Hits         4100     4100           
  Misses       2630     2630           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25eceb...48db076. Read the comment docs.

@JoelMarcey
Copy link
Contributor Author

Yep, that seemed to do it.

screenshot 2018-01-03 17 19 02

@JoelMarcey
Copy link
Contributor Author

So, I will leave it to you to approve this if and when you are ready to have facebook.github.io/jest updated with the backlog of stuff that has not been pushed yet.

Then we can merge :)

@cpojer cpojer merged commit 6896ee6 into master Jan 4, 2018
@cpojer
Copy link
Member

cpojer commented Jan 4, 2018

thanks @JoelMarcey for taking care of the website deploy!

@SimenB
Copy link
Member

SimenB commented Jan 4, 2018

Still not working, sorry to say.

remote: Permission to facebook/jest.git denied to docusaurus-bot.
fatal: unable to access 'https://[email protected]/facebook/jest.git/': The requested URL returned error: 403
Error: Git push failed

https://circleci.com/gh/facebook/jest/11219

@JoelMarcey
Copy link
Contributor Author

@SimenB It works, but for some reason, the docusaurus-bot is being removed as a user with write access from the Jest Collaborators and Teams :/

Some script must be running to make that happen, and I don't know what it is.

@JoelMarcey
Copy link
Contributor Author

I need to talk to our internal tooling team to see why. Give me a bit to figure out what is going on.

@JoelMarcey
Copy link
Contributor Author

Yep. Looks like we have either a bug or current GitHub API rate limitation in a script that allows us to add external collaborators to our repos. I will be pinging folks when they arrive into the office about this. This should hopefully get resolved sometime in the next couple of hours.

@JoelMarcey
Copy link
Contributor Author

Ok. We should be good to go now.

@JoelMarcey
Copy link
Contributor Author

Rebuilding #5201 on Circle....

@JoelMarcey
Copy link
Contributor Author

screenshot 2018-01-04 08 18 00

Yay! Finally!

@SimenB
Copy link
Member

SimenB commented Jan 4, 2018

Seems to have done the trick!

http://facebook.github.io/jest/docs/en/cli.html#changedfileswithancestor from #5189 is there.

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants