chore(package): update dev dependencies #5175
Conversation
| @@ -7,7 +7,7 @@ | |||
| "test": "jest" | |||
| }, | |||
| "dependencies": { | |||
| "react": "16.2.0", | |||
| "react": "16.0.0", | |||
There was a problem hiding this comment.
peer dep warning was annoying
There was a problem hiding this comment.
Can you downgrade to 16.0 but use a caret instead?
There was a problem hiding this comment.
Then we'll fail the peer dep again, won't we? Or does yarn check peer deps when resolving the tree?
There was a problem hiding this comment.
If I add a caret, we're back to the peer dep warning.
React-native has no range on its peer: https://github.com/facebook/react-native/blob/33a2e533b76d35c1b9fb32e926f7c2c27cb616e9/package.json#L144 (it's been updated to 16.2.0, but that's not released)
|
Need to downgrade eslint because of https://twitter.com/geteslint/status/944829414159810560 Upgrade of babel-eslint is blocked by facebook/fbjs#275 |
|
Seems like it’s failing node 8. On another note, can we change CI to run flow, lint etc on Node 8 or 9 instead of 6? It should be much faster on newer versions to run the full suite. |
|
We run lint on node 8 already, I snuck it in when we added node 9 CI :D Node 8 is failing because of an incompatibility between latest eslint and babel-eslint. I'll take eslint back a minor |
Codecov Report
@@ Coverage Diff @@
## master #5175 +/- ##
=======================================
Coverage 60.54% 60.54%
=======================================
Files 201 201
Lines 6707 6707
Branches 3 4 +1
=======================================
Hits 4061 4061
Misses 2645 2645
Partials 1 1Continue to review full report at Codecov.
|
|
Smart ;) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Just a periodic update 🙂
Test plan
Green CI