Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line before quitting watch mode #5158

Merged
merged 2 commits into from
Dec 22, 2017
Merged

Conversation

lorenzos
Copy link
Contributor

Prints a new line before quitting watch mode, to prevent mid-line shell prompts. More details in #5150.

@codecov-io
Copy link

Codecov Report

Merging #5158 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5158      +/-   ##
==========================================
- Coverage   60.66%   60.64%   -0.02%     
==========================================
  Files         201      201              
  Lines        6693     6695       +2     
  Branches        3        3              
==========================================
  Hits         4060     4060              
- Misses       2632     2634       +2     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/watch.js 73.75% <0%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72983d4...5c41af3. Read the comment docs.

@thymikee
Copy link
Collaborator

Can you post screenshots from various terminals (macOS Terminal, iTerm, Hyper)?

@lorenzos
Copy link
Contributor Author

lorenzos commented Dec 21, 2017

I'm on XFCE. I can show you how it looks on Hyper and on XFCE default terminal (both running Bash):

XFCE terminal

Before:

byzanz-record

After:

byzanz-record

Hyper

Before:

byzanz-record

After:

byzanz-record

@cpojer cpojer merged commit 95c0e5f into jestjs:master Dec 22, 2017
@cpojer
Copy link
Member

cpojer commented Dec 22, 2017

Looks good to me! Thanks for submitting a PR to Jest.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants