test(jest-message-util): add test for codeframe and snapshot test #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Dec 18, 2017
| @@ -2620,6 +2620,12 @@ errno@^0.1.1, errno@~0.1.1: | |||
| dependencies: | |||
There was a problem hiding this comment.
All changes in here come from running yarn after the 22 update
thymikee
approved these changes
Dec 18, 2017
SimenB
commented
Dec 18, 2017
| @@ -173,8 +173,8 @@ test('my mocking test', () => { | |||
| Jest 21 was released back in September, and we unfortunately never got around to | |||
| write a blog post. So here is a quick summary of the main changes in version 21: | |||
|
|
|||
| 1. **Use expect and jest-mock in the browser: | |||
| **[Michael Jackson](https://github.com/mjackson) donated his excellent | |||
| 1. **Use expect and jest-mock in the browser:** | |||
Codecov Report
@@ Coverage Diff @@
## master #5103 +/- ##
======================================
Coverage 60.6% 60.6%
======================================
Files 201 201
Lines 6688 6688
Branches 4 4
======================================
Hits 4053 4053
Misses 2635 2635Continue to review full report at Codecov.
|
|
Nice! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is just adding a regression test. This was broken and fixed in #5094, but I would like to have a test for it so we don't regress
Test plan
Green CI