Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract realpath native into a separate module #5097

Merged
merged 1 commit into from
Dec 17, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Dec 17, 2017

Summary
See #5085 (comment)

Quick and dirty extraction

Test plan
Green CI

@codecov-io
Copy link

Codecov Report

Merging #5097 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5097      +/-   ##
=========================================
- Coverage   60.66%   60.6%   -0.07%     
=========================================
  Files         201     201              
  Lines        6694    6688       -6     
  Branches        4       4              
=========================================
- Hits         4061    4053       -8     
- Misses       2633    2635       +2
Impacted Files Coverage Δ
packages/jest-util/src/index.js 100% <ø> (+9.52%) ⬆️
packages/jest-runtime/src/script_transformer.js 84.52% <100%> (-2.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb10f7a...22288df. Read the comment docs.

@cpojer cpojer merged commit de004b6 into jestjs:master Dec 17, 2017
@cpojer
Copy link
Member

cpojer commented Dec 17, 2017

Thank you!

@SimenB SimenB deleted the extract-realpath branch December 18, 2017 07:21
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants