optimize resolve #4325
optimize resolve #4325
Conversation
…tions. Test that a directory exists before attempting to resolve files within it.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for the cleanup, very nice! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Related to #2925. Clean up resolve() logic. Provide useful names for variables and functions. Test that a directory exists before attempting to resolve files within it.
Introduces slight performance improvements by testing whether a directory exists before attempting to resolve (potentially 10+) paths within the directory. Also tidies up code to meet style guidelines and usefully name variables + methods.
Test plan
Passes all tests.