Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing console.log messages #3895

Merged
merged 2 commits into from
Jun 23, 2017

Conversation

aaronabramov
Copy link
Contributor

@aaronabramov aaronabramov commented Jun 23, 2017

this is a split from #3882
fixes #3755

thanks @valerybugakov for finding this.
Console mesasges weren't being printed because we debounce the output for concurrent reporter, and some of the messages didn't have enough time to print before the process exits

@codecov-io
Copy link

Codecov Report

Merging #3895 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3895      +/-   ##
==========================================
- Coverage   58.07%   58.01%   -0.07%     
==========================================
  Files         195      195              
  Lines        6734     6741       +7     
  Branches        6        6              
==========================================
  Hits         3911     3911              
- Misses       2820     2827       +7     
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-cli/src/reporters/DefaultReporter.js 4.83% <0%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b1f79...6644b36. Read the comment docs.

@aaronabramov aaronabramov merged commit 04d05e5 into jestjs:master Jun 23, 2017
@aaronabramov aaronabramov deleted the fix-console-log branch June 23, 2017 23:16
@valerybugakov
Copy link
Contributor

@aaronabramov oh, cool!
I got stuck a bit with test case for this fix

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Ensure that console output is not lost in concurrent reporter

* console.log integration test + naming
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest swallows console output with --bail
4 participants