Make sure updateSnapshot propagates hasteContext.config #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the test is failing on AppVeyor? |
rogeliog
approved these changes
Apr 17, 2017
|
Skipped this on windows, because I have no idea what's wrong. We should come back to it after #3156 is merged |
Codecov Report
@@ Coverage Diff @@
## master #3298 +/- ##
==========================================
+ Coverage 63.95% 64.51% +0.56%
==========================================
Files 176 176
Lines 6484 6485 +1
Branches 4 4
==========================================
+ Hits 4147 4184 +37
+ Misses 2336 2300 -36
Partials 1 1
Continue to review full report at Codecov.
|
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* Make sure updateSnapshot propagates hasteContext.config * Skip test on windows * Lazy load jest-runtime for test * Update runJest-test.js
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Make sure updateSnapshot propagates hasteContext.config * Skip test on windows * Lazy load jest-runtime for test * Update runJest-test.js
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3297.
Test plan
Adds a very basic test for
runJest. To be updated after #3156.