Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-config): allow reporters in project config #14768

Merged
merged 9 commits into from
Dec 25, 2023
Merged

fix(jest-config): allow reporters in project config #14768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
56cd8ad
Update ValidConfig.ts
jeremiah-snee-openx Dec 20, 2023
906e862
update test-utils
jeremiah-snee-openx Dec 20, 2023
e04cbd1
Update Types config
jeremiah-snee-openx Dec 20, 2023
dad9674
Update Jest Config
jeremiah-snee-openx Dec 20, 2023
d306b40
fix test-utils config
jeremiah-snee-openx Dec 20, 2023
049c472
Update Snapshots
jeremiah-snee-openx Dec 20, 2023
722b9a6
Add changelog
jeremiah-snee-openx Dec 20, 2023
afcc4b6
move changelog entry
SimenB Dec 25, 2023
7e68dcb
Merge branch 'main' into Fix-Reporters-Validation
SimenB Dec 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
- `[jest-circus, jest-expect, jest-snapshot]` Pass `test.failing` tests when containing failing snapshot matchers ([#14313](https://github.com/jestjs/jest/pull/14313))
- `[jest-config]` Make sure to respect `runInBand` option ([#14578](https://github.com/facebook/jest/pull/14578))
- `[jest-config]` Support `testTimeout` in project config ([#14697](https://github.com/facebook/jest/pull/14697))
- `[jest-config]` Allow `reporters` in project config ([#14768](https://github.com/jestjs/jest/pull/14768))
- `[@jest/expect-utils]` Fix comparison of `DataView` ([#14408](https://github.com/jestjs/jest/pull/14408))
- `[@jest/expect-utils]` [**BREAKING**] exclude non-enumerable in object matching ([#14670](https://github.com/jestjs/jest/pull/14670))
- `[@jest/expect-utils]` Fix comparison of `URL` ([#14672](https://github.com/jestjs/jest/pull/14672))
Expand Down
5 changes: 5 additions & 0 deletions packages/jest-config/src/ValidConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,11 @@ export const initialProjectOptions: Config.InitialProjectOptions = {
openHandlesTimeout: 1000,
preset: 'react-native',
prettierPath: '<rootDir>/node_modules/prettier',
reporters: [
'default',
'custom-reporter-1',
['custom-reporter-2', {configValue: true}],
],
resetMocks: false,
resetModules: false,
resolver: '<rootDir>/resolver.js',
Expand Down
1 change: 1 addition & 0 deletions packages/jest-config/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ const groupOptions = (
modulePaths: options.modulePaths,
openHandlesTimeout: options.openHandlesTimeout,
prettierPath: options.prettierPath,
reporters: options.reporters,
resetMocks: options.resetMocks,
resetModules: options.resetModules,
resolver: options.resolver,
Expand Down
10 changes: 10 additions & 0 deletions packages/jest-core/src/lib/__tests__/__snapshots__/logDebugMessages.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,16 @@ exports[`prints the config object 1`] = `
"modulePaths": [],
"openHandlesTimeout": 1000,
"prettierPath": "prettier",
"reporters": [
"default",
"custom-reporter-1",
[
"custom-reporter-2",
{
"configValue": true
}
]
],
"resetMocks": false,
"resetModules": false,
"restoreMocks": false,
Expand Down
46 changes: 38 additions & 8 deletions packages/jest-transform/src/__tests__/__snapshots__/ScriptTransformer.test.ts.snap
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions packages/jest-types/src/Config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,7 @@ export type ProjectConfig = {
openHandlesTimeout: number;
preset?: string;
prettierPath: string;
reporters: Array<string | ReporterConfig>;
resetMocks: boolean;
resetModules: boolean;
resolver?: string;
Expand Down
5 changes: 5 additions & 0 deletions packages/test-utils/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ const DEFAULT_PROJECT_CONFIG: Config.ProjectConfig = {
modulePaths: [],
openHandlesTimeout: 1000,
prettierPath: 'prettier',
reporters: [
'default',
'custom-reporter-1',
['custom-reporter-2', {configValue: true}],
],
resetMocks: false,
resetModules: false,
resolver: undefined,
Expand Down
Loading