Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: equality of iterable with symbols #14688

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

DaniAcu
Copy link
Contributor

@DaniAcu DaniAcu commented Nov 9, 2023

Summary

Fixes #13936

Test plan

Copy link

linux-foundation-easycla bot commented Nov 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 123b9ec
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/655478ab4e834d0008b41c5a
😎 Deploy Preview https://deploy-preview-14688--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB enabled auto-merge (squash) November 15, 2023 07:52
@SimenB SimenB disabled auto-merge November 16, 2023 08:14
@SimenB SimenB merged commit 540c239 into jestjs:main Nov 16, 2023
69 of 73 checks passed
@SimenB
Copy link
Member

SimenB commented Nov 16, 2023

@DaniAcu DaniAcu deleted the fix/equality-of-iterable-with-symbols branch November 28, 2023 00:44
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: toEqual() doesn't work for iterable objects if objects have symbol property
2 participants