-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-circus) correct concurrent event ordering #14643
fix(jest-circus) correct concurrent event ordering #14643
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Question: should this be going into |
@madcapnmckay |
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I'm unsure if this is a major, minor, or patch change. It does not change the API, but it changes the order of events emitted from
jest-circus
Fixes the issue documented here.
When using
test.concurrent
events such astest_start
test_started
andtest_fn_start
would execute after the body of the test. This was due to the_runTest
not being executed as part of the parallel execution runner instead it was executed synchronously like non-concurrent tests.The solution was to use
_runTest
withinstartTestsConcurrently()
and then wait on that process to complete instead of replacing thetest.fn
as was being done before.Test plan
yarn test packages/jest-circus/src/__tests__/baseTest.test.ts
at commit 8175d9f` to observe the snapshot content for the concurrent test.yarn test packages/jest-circus/src/__tests__/baseTest.test.ts
and note that the output has been reordered to match the expectation that the circus actions occur before and after the test execution.