fix: make sure atob and btoa are writeable
#14446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hmm, no, this doesn't work. The assignment is just ignored… |
SimenB
commented
Aug 24, 2023
| // Node 19 makes performance non-readable. This is probably not the correct solution. | ||
| nodeGlobalsKey === 'performance', | ||
| value, | ||
| writable: true, |
There was a problem hiding this comment.
this is the only code change - if people wanna override globals, then sure 🤷
This was referenced Aug 28, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to solve the issue discovered in remix-run/remix#7220 where
atobandbtoa(amongst others) aren't writeable.Test plan
Tests in that repo passes. If CI is happy here, I'll add a test