chore: Update `@babel/*` deps #13422

liuxingbaoyu · 2022-10-10T11:15:02Z

Summary

Test plan

CI GREEN

liuxingbaoyu · 2022-10-10T11:56:15Z

This is technically correct, but the actual effect is not sure if it matters.
The ( of the previous function will be randomly mapped to the parent node, which may be the function name or function.

SimenB · 2022-10-10T13:26:03Z

Hmm, we should make sure to fix that trace - we wanna point at the it

liuxingbaoyu · 2022-10-10T13:31:13Z

An even worse news, here's a behavior change inside nodejs, too bad.🙃

examples/angular/package.json

nicolo-ribaudo · 2022-10-10T14:21:24Z

#13422 (comment)

For comparison, this is how Node.js reports the error when not using Babel:

var it = { each() { throw new Error("Err!") } }

it.each``();

Error: Err!
    at Object.each (/home/nic/Documents/dev/jest/demo.js:1:27)
    at Object.<anonymous> (/home/nic/Documents/dev/jest/demo.js:3:8)
    at Module._compile (node:internal/modules/cjs/loader:1120:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1174:10)
    at Module.load (node:internal/modules/cjs/loader:998:32)
    at Module._load (node:internal/modules/cjs/loader:839:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47

which points at this character:

it.each``();
//     ^

EDIT: Or this, depending on where jest throws the error (if in it.each, or if in the function returned by it.each)

var it = { each() { return () => { throw new Error("Err!") } } }

it.each``();

Error: Err!
    at Object.each (/home/nic/Documents/dev/jest/demo.js:1:27)
    at Object.<anonymous> (/home/nic/Documents/dev/jest/demo.js:3:10)
    at Module._compile (node:internal/modules/cjs/loader:1120:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1174:10)
    at Module.load (node:internal/modules/cjs/loader:998:32)
    at Module._load (node:internal/modules/cjs/loader:839:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47

which points at this character:

it.each``();
//       ^

The screenshot above matches exactly this second behavior.

liuxingbaoyu · 2022-10-10T14:23:57Z

I investigated and found out that the previous behavior was not the best either, nodejs would ideally output the code at the call site. For example assert(!!"") will output the following information

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

   assert(!!"")

Not sure what broke this before, causing it to just output false == true.
Now nodejs is able to partially successfully check the code at the call site, unfortunately it detects the wrong code, but I think we can just ignore this because our assert is wrapped and nodejs can never know when the real call is made code.

liuxingbaoyu · 2022-10-10T14:29:43Z

Wow, amazing test!
Yes, pointing to it may be technically difficult to implement, since the source map normally does not provide this information.
The first of the two cases should be able to handle, the second I'm not sure.
In the first case we can try to point near each, which will align with other behaviors.

EDIT: Seems a bit difficult as we are currently totally relying on the behavior of nodejs and nodejs doesn't implement this.

SimenB · 2022-10-10T17:14:30Z

Landed #13424 which does some of what this PR does to reduce the diff. Then merged main into this branch.

SimenB · 2022-10-11T01:00:50Z

packages/jest-each/src/bind.ts

-  ) =>
-    function eachBind(
+  ) => {
+    const error = new ErrorWithStack('', bindWrap);


nice! I actually opened this PR now to start working on this 😀 wonderful timing

liuxingbaoyu · 2022-10-11T01:50:41Z

There's still one problem left and I'm not quite sure how to fix it, do you have any suggestions?
test.*.each will capture and output the stack directly inside test.*, I have no chance to modify err.stack.

packages/jest-each/src/bind.ts

SimenB · 2022-10-11T03:47:38Z

e2e/__tests__/__snapshots__/testFailing.test.ts.snap

@@ -41,14 +41,12 @@ exports[`works with all statuses 1`] = `
      28 | });
      29 |
    > 30 | test.failing.each([
-         | ^
+         |              ^


this change is perfectly fine. would be even better to point at failing, but as long as it points to the test expression and not below the data I'm happy 😀

This is difficult unless we completely control source-map-support ourselves.😀

makes sense. And our usage of it is apparently broken anyways (see #9147)

e2e/__tests__/__snapshots__/testFailing.test.ts.snap

packages/jest-console/src/BufferedConsole.ts

packages/jest-console/src/__tests__/bufferedConsole.test.ts

liuxingbaoyu · 2022-10-11T05:05:40Z

This is really a nightmare.🙃

packages/jest-circus/src/index.ts

SimenB · 2022-10-11T05:14:55Z

This is really a nightmare.🙃

I think the fix should probably be in jest-jasmine2, not jest-each

liuxingbaoyu · 2022-10-11T05:16:28Z

This is really a nightmare.🙃

I think the fix should probably be in jest-jasmine2, not jest-each

I'm not sure this is a bug, seems to be serializing Error differently.

liuxingbaoyu · 2022-10-11T05:36:17Z

Oops, I found the reason, jest-jasmine2 was relying on the stack string, I replaced Error:.🤦‍♂️
CI should be green now!

SimenB

Can you add a changelog entry?

SimenB · 2022-10-11T05:44:28Z

packages/jest-each/src/bind.ts

-) {
-  return (
+  needsEachError = false,
+): Global.EachTestFn<any> {


Suggested change

): Global.EachTestFn<any> {

): Global.EachTestFn<unknown> {

ts seems to complain, I don't understand why.

CHANGELOG.md

SimenB

Yay! Thanks for taking the time to fix it - more work than expected! 😅

SimenB · 2022-10-14T09:17:08Z

https://github.com/facebook/jest/releases/tag/v29.2.0

github-actions · 2022-11-14T00:09:56Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

update

a6c0e50

facebook-github-bot added the cla signed label Oct 10, 2022

yarn constraints

9d67f64

tests

944fa61

liuxingbaoyu marked this pull request as draft October 10, 2022 13:23

SimenB reviewed Oct 10, 2022

View reviewed changes

examples/angular/package.json Outdated Show resolved Hide resolved

SimenB mentioned this pull request Oct 10, 2022

chore: update some babel deps #13424

Merged

SimenB added 2 commits October 10, 2022 10:07

rollback package.json changes

86c477e

Merge branch 'main' into update-babel-deps

eaa610b

SimenB and others added 4 commits October 10, 2022 10:15

up all again

ebb5390

update jasmine snaps

e71215c

one more jasmine snap

7783c4d

fix

89796db

SimenB reviewed Oct 11, 2022

View reviewed changes

snaps

f45b04e

liuxingbaoyu commented Oct 11, 2022

View reviewed changes

packages/jest-each/src/bind.ts Outdated Show resolved Hide resolved

liuxingbaoyu force-pushed the update-babel-deps branch from 1f8e2b5 to c8544d1 Compare October 11, 2022 02:31

fix

a39810a

liuxingbaoyu force-pushed the update-babel-deps branch from c8544d1 to a39810a Compare October 11, 2022 03:28

SimenB reviewed Oct 11, 2022

View reviewed changes

e2e/__tests__/__snapshots__/testFailing.test.ts.snap Show resolved Hide resolved

SimenB reviewed Oct 11, 2022

View reviewed changes

packages/jest-console/src/BufferedConsole.ts Show resolved Hide resolved

SimenB reviewed Oct 11, 2022

View reviewed changes

packages/jest-console/src/__tests__/bufferedConsole.test.ts Show resolved Hide resolved

liuxingbaoyu marked this pull request as ready for review October 11, 2022 05:05

fix and improve

7e73efd

liuxingbaoyu force-pushed the update-babel-deps branch from e44dc8c to 7e73efd Compare October 11, 2022 05:13

SimenB reviewed Oct 11, 2022

View reviewed changes

packages/jest-circus/src/index.ts Outdated Show resolved Hide resolved

review

7adfaa8

liuxingbaoyu force-pushed the update-babel-deps branch from 0de3b3c to 7adfaa8 Compare October 11, 2022 05:19

fix

16a0a36

SimenB approved these changes Oct 11, 2022

View reviewed changes

changelog

0db4273

SimenB reviewed Oct 11, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

c0f7c6d

SimenB approved these changes Oct 11, 2022

View reviewed changes

SimenB merged commit 7b67ecf into jestjs:main Oct 11, 2022

ms-bot mentioned this pull request Nov 7, 2022

Bump 🧳 jest to ^29.3.1 mobsuccess-devops/github-actions-mobsuccess#35

Closed

github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update `@babel/*` deps #13422

chore: Update `@babel/*` deps #13422

liuxingbaoyu commented Oct 10, 2022

liuxingbaoyu commented Oct 10, 2022

SimenB commented Oct 10, 2022

liuxingbaoyu commented Oct 10, 2022

nicolo-ribaudo commented Oct 10, 2022 •

edited

Loading

liuxingbaoyu commented Oct 10, 2022

liuxingbaoyu commented Oct 10, 2022 •

edited

Loading

SimenB commented Oct 10, 2022

SimenB Oct 11, 2022 •

edited

Loading

liuxingbaoyu commented Oct 11, 2022

SimenB Oct 11, 2022 •

edited

Loading

liuxingbaoyu Oct 11, 2022

SimenB Oct 11, 2022

liuxingbaoyu commented Oct 11, 2022

SimenB commented Oct 11, 2022

liuxingbaoyu commented Oct 11, 2022

liuxingbaoyu commented Oct 11, 2022

SimenB left a comment

SimenB Oct 11, 2022

liuxingbaoyu Oct 11, 2022

SimenB left a comment

SimenB commented Oct 14, 2022

github-actions bot commented Nov 14, 2022

chore: Update @babel/* deps #13422

chore: Update @babel/* deps #13422

Conversation

liuxingbaoyu commented Oct 10, 2022

Summary

Test plan

liuxingbaoyu commented Oct 10, 2022

SimenB commented Oct 10, 2022

liuxingbaoyu commented Oct 10, 2022

nicolo-ribaudo commented Oct 10, 2022 • edited Loading

liuxingbaoyu commented Oct 10, 2022

liuxingbaoyu commented Oct 10, 2022 • edited Loading

SimenB commented Oct 10, 2022

SimenB Oct 11, 2022 • edited Loading

Choose a reason for hiding this comment

liuxingbaoyu commented Oct 11, 2022

SimenB Oct 11, 2022 • edited Loading

Choose a reason for hiding this comment

liuxingbaoyu Oct 11, 2022

Choose a reason for hiding this comment

SimenB Oct 11, 2022

Choose a reason for hiding this comment

liuxingbaoyu commented Oct 11, 2022

SimenB commented Oct 11, 2022

liuxingbaoyu commented Oct 11, 2022

liuxingbaoyu commented Oct 11, 2022

SimenB left a comment

Choose a reason for hiding this comment

SimenB Oct 11, 2022

Choose a reason for hiding this comment

liuxingbaoyu Oct 11, 2022

Choose a reason for hiding this comment

SimenB left a comment

Choose a reason for hiding this comment

SimenB commented Oct 14, 2022

github-actions bot commented Nov 14, 2022

chore: Update `@babel/*` deps #13422

chore: Update `@babel/*` deps #13422

nicolo-ribaudo commented Oct 10, 2022 •

edited

Loading

liuxingbaoyu commented Oct 10, 2022 •

edited

Loading

SimenB Oct 11, 2022 •

edited

Loading

SimenB Oct 11, 2022 •

edited

Loading