fix(jest-environment-jsdom): add optional peer dependency on canvas #13409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methuselah96
force-pushed
the
jsdom-canvas-peer-dep
branch
from
90fb8c8 to
fefc33d
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jsdomhas an optional peer dependency on canvas in order to provide canvas support.jest-environment-jsdomdoes not forward this peer dependency and so canvas support does not work when using strict package managers like Yarn PnP. This PR propagates that optional peer dependency tojest-environment-jsdomsince peer dependencies should be forwarded in order for the child package to have access to the peer dependency.Test plan
N/A? I don't know how to easily write an automated test this, let me know if there's a way.