Setup admonitions. #12495 #13304
Setup admonitions. #12495 #13304
Conversation
docs/SetupAndTeardown.md
Outdated
| @@ -97,7 +97,11 @@ describe('matching cities to foods', () => { | |||
| }); | |||
| ``` | |||
|
|
|||
| Note that the top-level `beforeEach` is executed before the `beforeEach` inside the `describe` block. It may help to illustrate the order of execution of all hooks. | |||
| :::note | |||
There was a problem hiding this comment.
No need of this. The order is illustrated just below, but this is also illustration for the code above. Semantically this is just one piece of text and need to change anything.
docs/SetupAndTeardown.md
Outdated
| Just like the `describe` and `test` blocks Jest calls the `before*` and `after*` hooks in the order of declaration. | ||
|
|
||
| :::note | ||
|
|
||
| The `after*` hooks of the enclosing scope are called first. For example, here is how you can set up and tear down resources which depend on each other: | ||
|
|
||
| ::: |
There was a problem hiding this comment.
Also here there is no need to change anything. It does not look good or logic to end the note with a colon. Also this splitting does not make sense, because this is just one piece of text.
|
Okay so for this one should I just close the PR? @mrazauskas |
paulreece
force-pushed
the
setup_admonitions
branch
from
39f4bc3 to
e9696bb
Compare
|
I'm closing this one. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Test plan