-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: configuration admonitions #13295
Conversation
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of changes here. Just to clean it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. My eye found few more details to fix.
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
@mrazauskas Let me know if there's anything else. Also do we need to tag SimenB in all of these for merging? |
Thanks. One more detail, please. No need to ping Simen. He will look through. Just wait bit (; |
Co-authored-by: Tom Mrazauskas <[email protected]>
Thanks. All looks good. Now only v29.1 missing. 29.1 docs got added on |
@mrazauskas I added 29.1 to this branch and I went through line by line comparisons of that with 29.0 and there was nothing to add that wasn't already there. If you see any differences or other stuff to add please let me know. |
Thanks. Hm.. GH should show diff for 29.1, just like in #13310. Could you merge |
@SimenB Thanks for your help. @mrazauskas How does it look now? |
Hm.. Now v29.1 went missing. Could you take a look, please? |
@mrazauskas I think it disappeared because Simen merged the main branch and there were no differences in what I had versus the main branch. I looked through the file in main and I'm not sure that there's anything to add for 29.1 on this. |
To simplify everything – I just created #13364 which deals with 29.1 version of the docs. So landing these two PRs would fix all the versions and this last piece is also done! Thanks for all the job you have done. And thanks for tolerating me (; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Test plan