Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: configuration admonitions #13295

Merged
merged 28 commits into from
Oct 3, 2022
Merged

Conversation

paulreece
Copy link
Contributor

Summary

Test plan

@paulreece paulreece changed the title Configuration admonitions. Configuration admonitions. #12495 Sep 22, 2022
paulreece and others added 5 commits September 24, 2022 15:13
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Co-authored-by: Tom Mrazauskas <[email protected]>
Copy link
Contributor

@mrazauskas mrazauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of changes here. Just to clean it up.

Copy link
Contributor

@mrazauskas mrazauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. My eye found few more details to fix.

@paulreece
Copy link
Contributor Author

@mrazauskas Let me know if there's anything else. Also do we need to tag SimenB in all of these for merging?

@mrazauskas
Copy link
Contributor

Thanks. One more detail, please.

No need to ping Simen. He will look through. Just wait bit (;

@mrazauskas
Copy link
Contributor

Thanks. All looks good. Now only v29.1 missing.

29.1 docs got added on main. You should rebase this branch.

@paulreece
Copy link
Contributor Author

@mrazauskas I added 29.1 to this branch and I went through line by line comparisons of that with 29.0 and there was nothing to add that wasn't already there. If you see any differences or other stuff to add please let me know.

@mrazauskas
Copy link
Contributor

Thanks. Hm.. GH should show diff for 29.1, just like in #13310. Could you merge main into this branch as well? That should be enough.

@paulreece
Copy link
Contributor Author

@SimenB Thanks for your help. @mrazauskas How does it look now?

@mrazauskas
Copy link
Contributor

Hm.. Now v29.1 went missing. Could you take a look, please?

@paulreece
Copy link
Contributor Author

paulreece commented Sep 30, 2022

@mrazauskas I think it disappeared because Simen merged the main branch and there were no differences in what I had versus the main branch. I looked through the file in main and I'm not sure that there's anything to add for 29.1 on this.

@mrazauskas
Copy link
Contributor

To simplify everything – I just created #13364 which deals with 29.1 version of the docs. So landing these two PRs would fix all the versions and this last piece is also done!

Thanks for all the job you have done. And thanks for tolerating me (;

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@SimenB SimenB changed the title Configuration admonitions. #12495 docs: configuration admonitions Oct 3, 2022
@SimenB SimenB merged commit 469f3a5 into jestjs:main Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants