-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@jest/reporters): GitHubActionsReporter
version 2
#12822
feat(@jest/reporters): GitHubActionsReporter
version 2
#12822
Conversation
Exciting! Where is this summary printed? Can't find it 😅 |
Here (under all annotations): https://github.com/facebook/jest/actions/runs/2288677934 It must be markdown. So I used badges to bring in some colors (inspired by Renovate). Will improve it a bit. |
I will split annotation to separate PR. Perhaps that will help to see what is wrong. Now about summaries. They look like this: Each step in a job gets a summary. That’s a lot of summaries in this repo. For instance, TS summary at first looks duplicated. It is not (; These are two steps: type test on latest TS and type tests on TS 4.3. Actual duration looks rather odd, but apparently it is correct. Seems like these can be useful to check quickly what is happening. I will try to add few details, e.g. a link to jump directly to a log of some failing jobs would be nice. Ah.. Link to summaries (they live at the bottom, under all annotations): https://github.com/facebook/jest/actions/runs/2289939027 |
vaguely related: https://twitter.com/github/status/1525550263850909696 |
Thanks! It would be really cool to have a result like in their picture. |
@mrazauskas what's the status here? 🙂 |
Oh.. I was playing with svg's and got overexcited ;D I look go through the experiments and will try to wrap this up next week. |
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Not sure this is really useful. It needs more thinking and adds a lot of code as well. Closing for now. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Annotations from
GitHubActionsReporter
is a great feature. Let’s make it even better:Error
;There is more. @martinwoodward drop me a message saying that GitHub Actions soon will have a possibility to add a job summary. Would it be interested to try out this upcoming feature? Sure, let’s try it right out now. Thanks, Martin!
Test plan
Unit test are added. Also some temporary failing tests are included to see the output.