Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rootDir to mergedBabelTransformOptions #12331

Closed
wants to merge 1 commit into from

Conversation

twheys
Copy link

@twheys twheys commented Feb 8, 2022

Summary

I am currently working with a monorepo project where the root directory of the UI module is a subdirectory the project's root directory. Both my jest.config.json and babelrc.json files are in the UI module's root dir. The build tool we are using for our project forces us to run Jest from the project root, rather than the UI module's root. Jest uses the directory of the jest.config.json file by default, but babel uses the current working directory.

In order to fix this, babel-jest must set the root option in the babel configuration to jest's rootDir.

Running jest from a different working directory other than the project root causes the babel configuration to fail to load. The Babel configuration accepts a "root" argument, however, babel-jest is not currently passing this along.
@facebook-github-bot
Copy link
Contributor

Hi @twheys!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Feb 8, 2022

CI is super unhappy 😃

Also, this needs a test to show what this enables that the current approach doesn't.

@twheys
Copy link
Author

twheys commented Feb 9, 2022

@SimenB thanks for the quick response, yeah I saw the build failures. Trying to debug an issue with a Bazel build using jest+babel here. Just wanted to test the waters and see if my small change would break anything. Still investigating, so will address this when I get a working solution.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants