Use globalThis (with fallback if needed) instead of global to enable esbuild support
#11569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using `global`, the package `pretty-format` can not be bundled for the browser by `esbuild` because `global` is not defined in a browser environment. Switching to `globalThis`, with a polyfill for older environments, allows `pretty-format` (and hopefully other packages) to be bundled by `esbuild --platform browser`.
Codecov Report
@@ Coverage Diff @@
## master #11569 +/- ##
==========================================
- Coverage 69.00% 69.00% -0.01%
==========================================
Files 312 312
Lines 16331 16331
Branches 4730 4730
==========================================
- Hits 11270 11269 -1
- Misses 5033 5034 +1
Partials 28 28
Continue to review full report at Codecov.
|
JakeChampion
added a commit
to Financial-Times/o-autocomplete
that referenced
this pull request
Jun 15, 2021
SimenB
approved these changes
Jun 15, 2021
SimenB
approved these changes
Jun 15, 2021
SimenB
changed the title
globalThis (with polyfill if needed) instead of global to enable esbuild supportglobalThis (with fallback if needed) instead of global to enable esbuild support
JakeChampion
added a commit
to Financial-Times/o-autocomplete
that referenced
this pull request
Jun 28, 2021
We are not using any of the features which were removed or changed in the new version. The new version also removes the need for the hack.js file we needed to use this is because, the package is using the latest major versio of pretty-format, which contains this update jestjs/jest#11569
JakeChampion
added a commit
to Financial-Times/o-autocomplete
that referenced
this pull request
Jun 30, 2021
We are not using any of the features which were removed or changed in the new version. The new version also removes the need for the hack.js file we needed to use this is because, the package is using the latest major versio of pretty-format, which contains this update jestjs/jest#11569
JakeChampion
added a commit
to Financial-Times/o-autocomplete
that referenced
this pull request
Jul 1, 2021
We are not using any of the features which were removed or changed in the new version. The new version also removes the need for the hack.js file we needed to use this is because, the package is using the latest major versio of pretty-format, which contains this update jestjs/jest#11569
JakeChampion
added a commit
to Financial-Times/o-autocomplete
that referenced
this pull request
Jul 6, 2021
JakeChampion
added a commit
to Financial-Times/o-autocomplete
that referenced
this pull request
Jul 6, 2021
We are not using any of the features which were removed or changed in the new version. The new version also removes the need for the hack.js file we needed to use this is because, the package is using the latest major versio of pretty-format, which contains this update jestjs/jest#11569
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The motivation for this pull-request is to get the jest packages such as
pretty-formatto work with esbuild when targeting the browser platform. This is because @testing-library/dom uses pretty-format and I am trying to use that package as part of my testing setup.By using
global, the packagepretty-formatcan not be bundled for the browser byesbuildbecauseglobalis not defined in a browser environment.Switching to
globalThis, with a polyfill for older environments, allowspretty-format(and hopefully other packages) to be bundled byesbuild --platform browser.Test plan
The change does not modify any logic of Jest's packages, it only adds a polyfill for
globalThis.A way to test this change will solve my original problem would be to build the project and then attempt to bundle
pretty-formatwithesbuild --bundle --target=es2020 --platform=browserand run the bundle in a browser environment.Before
Building from master branch:
Running the bundle in the browser gives an Error
Uncaught ReferenceError: global is not definedAfter
Building from globalthis branch:
Running the bundle in the browser gives no error:
