Fix unhandled ERR_IPC_CHANNEL_CLOSED and a deadlock #11144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11144 +/- ##
==========================================
+ Coverage 64.18% 64.20% +0.01%
==========================================
Files 307 307
Lines 13370 13370
Branches 3262 3262
==========================================
+ Hits 8582 8584 +2
+ Misses 4083 4082 -1
+ Partials 705 704 -1
Continue to review full report at Codecov.
|
jeysal
reviewed
Mar 6, 2021
| @@ -205,6 +205,7 @@ export default class ChildProcessWorker implements WorkerInterface { | |||
| private _onExit(exitCode: number) { | |||
There was a problem hiding this comment.
Suggested change
| private _onExit(exitCode: number) { | |
| private _onExit(exitCode: number | null) { |
SimenB
approved these changes
Mar 6, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detailed description is at #11143.
Fixes #11143