Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-snapshot v25 requires a version of semver which doesn't support node 8 #9450

Closed
grxy opened this issue Jan 23, 2020 · 8 comments · Fixed by #9451
Closed

jest-snapshot v25 requires a version of semver which doesn't support node 8 #9450

grxy opened this issue Jan 23, 2020 · 8 comments · Fixed by #9451

Comments

@grxy
Copy link
Contributor

grxy commented Jan 23, 2020

🐛 Bug Report

jest-snapshot v25 requires a version of semver which doesn't support node 8

To Reproduce

Steps to reproduce the behavior:

  1. Set node version to 8
  2. yarn init a package
  3. Run yarn add jest

image

Expected behavior

Jest is successfully added to the package manifest.

Link to repl or repo (highly encouraged)

envinfo

  System:
    OS: macOS Mojave 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 8.17.0 - ~/.nvm/versions/node/v8.17.0/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.13.4 - ~/.nvm/versions/node/v8.17.0/bin/npm
@ljharb
Copy link
Contributor

ljharb commented Jan 23, 2020

I believe semver 7 and 6 are largely identical except for node version support; downgrading to semver 6 should address it.

@grxy
Copy link
Contributor Author

grxy commented Jan 23, 2020

@ljharb I'll put up a PR shortly.

@francois-codes
Copy link

francois-codes commented Jan 28, 2020

@SimenB does this mean that support for node 8 is dropped ? I don't see how this PR solves the current issue

@SimenB
Copy link
Member

SimenB commented Jan 28, 2020

What? I have no idea how that's your conclusion - we've rolled back to a version that still supports older nodes, it's just not released yet

@francois-codes
Copy link

My bad, I checked the wrong reference for the fix 🤦‍♂
Do you know when this is planned to be released ?

@SimenB
Copy link
Member

SimenB commented Jan 28, 2020

#9451 (comment)

sverweij added a commit to sverweij/upem that referenced this issue Feb 2, 2020
@protoEvangelion
Copy link

@SimenB any progress on a new release for this?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants