-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest-cli] Please update node-notifier to fix memory leak #5365
[jest-cli] Please update node-notifier to fix memory leak #5365
Comments
Mind sending a PR? 🙂 |
We are within semver range (fix is apparently in 5.2.1), so not sure we need to do anything? https://github.com/facebook/jest/blob/139f976b67f40b286a73860c1f59def712ec323d/packages/jest-cli/package.json#L32 Doesn't hurt to update, of course. |
Ahm, did a PR (should I update Indeed it's in semver range, after removing But for most people it will not update and already installed |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When running tests with
--notify
, in some situations there's a memory leak in theterminal-notifier
process which eats up all of the computer RAM.If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can
yarn install
andyarn test
.This has been reported in:
#2999
I've started experiencing the issue with my team recently, after upgrading to Jest
v22.x.x
(not sure if it's related, and probably doesn't matter now).What is the expected behavior?
Looks like the issue has been fixed in latest
node-notifier
:mikaelbr/node-notifier#183
So, if we bump
node-notifier
, the issue should go away.Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.
I couldn't pin down exactly in what scenario it happens, #2999 has a repro though.
Mac OS X 10.12.6
Jest v22.1.2
Node v9.3.0
The text was updated successfully, but these errors were encountered: